Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Mar 14, 2025

Proposed Changes

Remove Bazel files. We are no longer using Bazel to build or to test. Bazel was a great tool for our team,
it provided a much needed capability of caching and build optimisation. However, in recent times, we decided
to focus on Make and erlang.mk, thus this PR has taken place.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Closes #13494


This is an automatic backport of pull request #13514 done by [Mergify](https://mergify.com).

@mergify
Copy link
Author

mergify bot commented Mar 14, 2025

Cherry-pick of 07adc3e has failed:

On branch mergify/bp/v4.1.x/pr-13514
Your branch is up to date with 'origin/v4.1.x'.

You are currently cherry-picking commit 07adc3e57.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    .bazelignore
	deleted:    .bazelrc
	deleted:    .bazelversion
	modified:   .github/mergify.yml
	deleted:    .github/workflows/check-build-system-equivalence-release-branches.yaml
	deleted:    .github/workflows/check-build-system-equivalence.yaml
	deleted:    .github/workflows/gazelle-scheduled.yaml
	deleted:    .github/workflows/gazelle.yaml
	deleted:    .github/workflows/templates/test-mixed-versions.template.yaml
	deleted:    .github/workflows/templates/test.template.yaml
	modified:   .github/workflows/test-authnz.yaml
	modified:   .github/workflows/test-management-ui.yaml
	deleted:    .github/workflows/test-mixed-versions.yaml
	deleted:    .github/workflows/test-plugin-mixed.yaml
	deleted:    .github/workflows/test-plugin.yaml
	deleted:    .github/workflows/test-windows.yaml
	deleted:    .github/workflows/test.yaml
	modified:   .gitignore
	deleted:    BAZEL.md
	deleted:    BUILD.bats
	deleted:    BUILD.bazel
	deleted:    BUILD.package_generic_unix
	deleted:    MODULE.bazel
	modified:   Makefile
	deleted:    WORKSPACE
	deleted:    bazel/BUILD.accept
	deleted:    bazel/BUILD.amqp
	deleted:    bazel/BUILD.aten
	deleted:    bazel/BUILD.base64url
	deleted:    bazel/BUILD.bazel
	deleted:    bazel/BUILD.cowboy
	deleted:    bazel/BUILD.cowlib
	deleted:    bazel/BUILD.credentials_obfuscation
	deleted:    bazel/BUILD.csv
	deleted:    bazel/BUILD.ct_helper
	deleted:    bazel/BUILD.cuttlefish
	deleted:    bazel/BUILD.eetcd
	deleted:    bazel/BUILD.emqtt
	deleted:    bazel/BUILD.enough
	deleted:    bazel/BUILD.ex_doc
	deleted:    bazel/BUILD.gen_batch_server
	deleted:    bazel/BUILD.getopt
	deleted:    bazel/BUILD.gun
	deleted:    bazel/BUILD.horus
	deleted:    bazel/BUILD.jose
	deleted:    bazel/BUILD.json
	deleted:    bazel/BUILD.khepri
	deleted:    bazel/BUILD.khepri_mnesia_migration
	deleted:    bazel/BUILD.meck
	deleted:    bazel/BUILD.observer_cli
	deleted:    bazel/BUILD.prometheus
	deleted:    bazel/BUILD.proper
	deleted:    bazel/BUILD.quantile_estimator
	deleted:    bazel/BUILD.ra
	deleted:    bazel/BUILD.ranch
	deleted:    bazel/BUILD.recon
	deleted:    bazel/BUILD.redbug
	deleted:    bazel/BUILD.seshat
	deleted:    bazel/BUILD.stdout_formatter
	deleted:    bazel/BUILD.syslog
	deleted:    bazel/BUILD.sysmon_handler
	deleted:    bazel/BUILD.systemd
	deleted:    bazel/BUILD.temp
	deleted:    bazel/BUILD.thoas
	deleted:    bazel/BUILD.x509
	deleted:    bazel/amqp.patch
	deleted:    bazel/bzlmod/BUILD.bazel
	deleted:    bazel/bzlmod/extensions.bzl
	deleted:    bazel/bzlmod/secondary_umbrella.bzl
	deleted:    bazel/elixir/BUILD.bazel
	deleted:    bazel/elixir/elixir_escript_main.bzl
	deleted:    bazel/elixir/elixir_escript_main.exs
	deleted:    bazel/elixir/mix_archive_build.bzl
	deleted:    bazel/elixir/mix_archive_extract.bzl
	deleted:    bazel/util/BUILD.bazel
	deleted:    bazel/util/ct_logdir_vars.bzl
	deleted:    deps/amqp10_client/BUILD.bazel
	deleted:    deps/amqp10_client/activemq.bzl
	deleted:    deps/amqp10_client/app.bzl
	deleted:    deps/amqp10_common/BUILD.bazel
	deleted:    deps/amqp10_common/app.bzl
	deleted:    deps/amqp_client/BUILD.bazel
	deleted:    deps/amqp_client/app.bzl
	deleted:    deps/oauth2_client/BUILD.bazel
	deleted:    deps/oauth2_client/app.bzl
	deleted:    deps/rabbit/bats.bzl
	deleted:    deps/rabbit/test/feature_flags_SUITE_data/my_plugin/BUILD.bazel
	deleted:    deps/rabbit_common/BUILD.bazel
	deleted:    deps/rabbit_common/app.bzl
	deleted:    deps/rabbitmq_amqp1_0/BUILD.bazel
	deleted:    deps/rabbitmq_amqp1_0/app.bzl
	deleted:    deps/rabbitmq_amqp_client/BUILD.bazel
	deleted:    deps/rabbitmq_amqp_client/app.bzl
	deleted:    deps/rabbitmq_auth_backend_cache/BUILD.bazel
	deleted:    deps/rabbitmq_auth_backend_http/BUILD.bazel
	deleted:    deps/rabbitmq_auth_backend_http/app.bzl
	deleted:    deps/rabbitmq_auth_backend_ldap/BUILD.bazel
	deleted:    deps/rabbitmq_auth_backend_ldap/app.bzl
	deleted:    deps/rabbitmq_auth_backend_oauth2/BUILD.bazel
	deleted:    deps/rabbitmq_auth_backend_oauth2/app.bzl
	deleted:    deps/rabbitmq_auth_mechanism_ssl/BUILD.bazel
	deleted:    deps/rabbitmq_auth_mechanism_ssl/app.bzl
	deleted:    deps/rabbitmq_aws/BUILD.bazel
	deleted:    deps/rabbitmq_aws/app.bzl
	deleted:    deps/rabbitmq_cli/BUILD.bazel
	deleted:    deps/rabbitmq_cli/rabbitmqctl.bzl
	deleted:    deps/rabbitmq_codegen/BUILD.bazel
	deleted:    deps/rabbitmq_consistent_hash_exchange/BUILD.bazel
	deleted:    deps/rabbitmq_consistent_hash_exchange/app.bzl
	deleted:    deps/rabbitmq_ct_client_helpers/BUILD.bazel
	deleted:    deps/rabbitmq_ct_client_helpers/WORKSPACE.bazel
	deleted:    deps/rabbitmq_ct_client_helpers/app.bzl
	deleted:    deps/rabbitmq_ct_helpers/BUILD.bazel
	deleted:    deps/rabbitmq_ct_helpers/app.bzl
	deleted:    deps/rabbitmq_event_exchange/BUILD.bazel
	deleted:    deps/rabbitmq_event_exchange/app.bzl
	deleted:    deps/rabbitmq_federation/BUILD.bazel
	deleted:    deps/rabbitmq_federation/app.bzl
	deleted:    deps/rabbitmq_federation_management/BUILD.bazel
	deleted:    deps/rabbitmq_federation_management/app.bzl
	deleted:    deps/rabbitmq_federation_prometheus/BUILD.bazel
	deleted:    deps/rabbitmq_federation_prometheus/app.bzl
	deleted:    deps/rabbitmq_jms_topic_exchange/BUILD.bazel
	deleted:    deps/rabbitmq_jms_topic_exchange/app.bzl
	deleted:    deps/rabbitmq_management/BUILD.bazel
	deleted:    deps/rabbitmq_management/app.bzl
	deleted:    deps/rabbitmq_management_agent/BUILD.bazel
	deleted:    deps/rabbitmq_management_agent/app.bzl
	deleted:    deps/rabbitmq_mqtt/app.bzl
	deleted:    deps/rabbitmq_peer_discovery_aws/BUILD.bazel
	deleted:    deps/rabbitmq_peer_discovery_aws/app.bzl
	deleted:    deps/rabbitmq_peer_discovery_common/BUILD.bazel
	deleted:    deps/rabbitmq_peer_discovery_common/app.bzl
	deleted:    deps/rabbitmq_peer_discovery_consul/BUILD.bazel
	deleted:    deps/rabbitmq_peer_discovery_consul/app.bzl
	deleted:    deps/rabbitmq_peer_discovery_etcd/BUILD.bazel
	deleted:    deps/rabbitmq_peer_discovery_etcd/app.bzl
	deleted:    deps/rabbitmq_peer_discovery_k8s/BUILD.bazel
	deleted:    deps/rabbitmq_peer_discovery_k8s/app.bzl
	deleted:    deps/rabbitmq_prelaunch/BUILD.bazel
	deleted:    deps/rabbitmq_prelaunch/app.bzl
	deleted:    deps/rabbitmq_prometheus/BUILD.bazel
	deleted:    deps/rabbitmq_prometheus/app.bzl
	deleted:    deps/rabbitmq_random_exchange/BUILD.bazel
	deleted:    deps/rabbitmq_random_exchange/app.bzl
	deleted:    deps/rabbitmq_recent_history_exchange/BUILD.bazel
	deleted:    deps/rabbitmq_recent_history_exchange/app.bzl
	deleted:    deps/rabbitmq_sharding/BUILD.bazel
	deleted:    deps/rabbitmq_sharding/app.bzl
	deleted:    deps/rabbitmq_shovel/BUILD.bazel
	deleted:    deps/rabbitmq_shovel/app.bzl
	deleted:    deps/rabbitmq_shovel_management/BUILD.bazel
	deleted:    deps/rabbitmq_shovel_management/app.bzl
	deleted:    deps/rabbitmq_shovel_prometheus/BUILD.bazel
	deleted:    deps/rabbitmq_shovel_prometheus/app.bzl
	deleted:    deps/rabbitmq_stomp/BUILD.bazel
	deleted:    deps/rabbitmq_stomp/app.bzl
	deleted:    deps/rabbitmq_stream/BUILD.bazel
	deleted:    deps/rabbitmq_stream/app.bzl
	deleted:    deps/rabbitmq_stream_common/BUILD.bazel
	deleted:    deps/rabbitmq_stream_common/app.bzl
	deleted:    deps/rabbitmq_stream_management/BUILD.bazel
	deleted:    deps/rabbitmq_stream_management/app.bzl
	deleted:    deps/rabbitmq_top/BUILD.bazel
	deleted:    deps/rabbitmq_top/app.bzl
	deleted:    deps/rabbitmq_tracing/BUILD.bazel
	deleted:    deps/rabbitmq_tracing/app.bzl
	deleted:    deps/rabbitmq_trust_store/BUILD.bazel
	deleted:    deps/rabbitmq_trust_store/app.bzl
	deleted:    deps/rabbitmq_web_dispatch/BUILD.bazel
	deleted:    deps/rabbitmq_web_dispatch/app.bzl
	deleted:    deps/rabbitmq_web_mqtt/BUILD.bazel
	deleted:    deps/rabbitmq_web_mqtt/app.bzl
	deleted:    deps/rabbitmq_web_mqtt_examples/BUILD.bazel
	deleted:    deps/rabbitmq_web_mqtt_examples/app.bzl
	deleted:    deps/rabbitmq_web_stomp/BUILD.bazel
	deleted:    deps/rabbitmq_web_stomp/app.bzl
	deleted:    deps/rabbitmq_web_stomp_examples/BUILD.bazel
	deleted:    deps/rabbitmq_web_stomp_examples/app.bzl
	deleted:    deps/trust_store_http/BUILD.bazel
	deleted:    deps/trust_store_http/app.bzl
	deleted:    dist.bzl
	deleted:    mk/bazel.mk
	deleted:    packaging/BUILD.bazel
	modified:   packaging/docker-image/.dockerignore
	deleted:    packaging/docker-image/BUILD.bazel
	deleted:    packaging/docker-image/test_configs/BUILD.bazel
	deleted:    rabbitmq.bzl
	deleted:    rabbitmq_home.bzl
	deleted:    rabbitmq_package_generic_unix.bzl
	deleted:    rabbitmq_run.bzl
	deleted:    rabbitmqctl.bzl
	deleted:    scripts/bazel/kill_orphaned_ct_run.sh
	deleted:    scripts/bazel/rabbitmq-run.bat
	deleted:    scripts/bazel/rabbitmq-run.sh
	deleted:    tools/BUILD.bazel
	deleted:    tools/compare_dist.sh
	deleted:    tools/erlang_app_equal
	deleted:    tools/erlang_ls.bzl
	deleted:    user-template.bazelrc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: deps/rabbit/BUILD.bazel
	deleted by them: deps/rabbit/app.bzl
	deleted by them: deps/rabbitmq_auth_backend_cache/app.bzl
	deleted by them: deps/rabbitmq_mqtt/BUILD.bazel

Cherry-pick of 43f9991 has failed:

On branch mergify/bp/v4.1.x/pr-13514
Your branch is ahead of 'origin/v4.1.x' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 43f99912d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Makefile

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: moduleindex.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned Zerpet Mar 14, 2025
@mergify mergify bot added the make label Mar 14, 2025
Zerpet added 2 commits March 14, 2025 12:39
(cherry picked from commit 07adc3e)
(cherry picked from commit 43f9991)
@Zerpet Zerpet force-pushed the mergify/bp/v4.1.x/pr-13514 branch from 1679a0b to ac7b9fe Compare March 14, 2025 12:39
@Zerpet Zerpet merged commit bf0d5a0 into v4.1.x Mar 14, 2025
274 checks passed
@Zerpet Zerpet deleted the mergify/bp/v4.1.x/pr-13514 branch March 14, 2025 13:55
Zerpet added a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants